Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hbs tags are stripped when there is a comment below or inline #1461

Closed
astronomersiva opened this issue Jul 30, 2018 · 1 comment
Closed

Comments

@astronomersiva
Copy link

Description

In HBS files, if there is a comment inline or below an HBS tag, the tag is stripped off.

Case 1

Input

The code looked like this before beautification:

{{hello "world"}} {{!-- this is comment --}}

Expected Output

The code should have looked like this after beautification:

{{hello "world"}} {{!-- this is comment --}}

Actual Output

The code actually looked like this after beautification:

{{!-- this is comment --}}

Case 2

Input

The code looked like this before beautification:

{{hello "world"}}
{{!-- this is comment --}}
{{hello "again"}}

Expected Output

The code should have looked like this after beautification:

{{hello "world"}}
{{!-- this is comment --}}
{{hello "again"}}

Actual Output

The code actually looked like this after beautification:

{{!-- this is comment --}}
{{hello
  "world2"}}
@bitwiseman
Copy link
Member

Fixed in 1.8.0-rc3.

bitwiseman added a commit that referenced this issue Jul 31, 2018
@bitwiseman bitwiseman modified the milestones: v1.8.x, 1.8.0-rc3 Jul 31, 2018
@bitwiseman bitwiseman modified the milestones: 1.8.0-rc4, 1.8.0 Aug 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants