Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

_get_full_indent undefined #1590

Closed
coolph007 opened this issue Nov 10, 2018 · 2 comments
Closed

_get_full_indent undefined #1590

coolph007 opened this issue Nov 10, 2018 · 2 comments
Labels
language: html type: bug
Milestone
v1.9.0

Comments

@coolph007
Copy link

Please rename _get_full_indent to get_full_indent; else code is throwing undefined _get_full_indent.
@bitwiseman
Copy link
Member

@ADITYACODER007 Please describe how to reproduce the error you are seeing.

@bitwiseman
Copy link
Member

bitwiseman commented Nov 12, 2018 •
edited
Loading

Ah, I see.

https://github.com/beautify-web/js-beautify/blob/2f8e4f050200b85f3c3b9fb5a292823b52c618ac/js/src/html/beautifier.js#L442-L455

The case where _beautifier is not defined is not covered by tests.

bitwiseman added a commit to bitwiseman/js-beautify that referenced this issue Dec 9, 2018
@bitwiseman
Fix null beautifier and add tests
96876ed 
Fixes beautifier#1590
bitwiseman added a commit to bitwiseman/js-beautify that referenced this issue Dec 9, 2018
@bitwiseman
Fix null beautifier and add tests
714fb95 
Fixes beautifier#1590
@bitwiseman bitwiseman modified the milestones: v2.0.0, v1.8.x Dec 9, 2018
@bitwiseman bitwiseman modified the milestones: v1.9.x, v1.9.0 Feb 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
language: html type: bug
Projects
None yet
Milestone
v1.9.0
Development

No branches or pull requests
2 participants
@bitwiseman @coolph007