Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Logical assignments in JS are incorrectly beautified #1991

Closed
mhnaeem opened this issue Mar 4, 2022 · 2 comments
Closed

[Bug] Logical assignments in JS are incorrectly beautified #1991

mhnaeem opened this issue Mar 4, 2022 · 2 comments

Comments

@mhnaeem
Copy link
Contributor

mhnaeem commented Mar 4, 2022

Description

The tool incorrectly beautifies logical AND, OR and NULL assignments.

Links:

Input

The code looked like this before beautification:

x&&=y
x||=y
x??=y

Expected Output

The code should have looked like this after beautification:

x &&= y
x ||= y
x ??= y

Actual Output

The code actually looked like this after beautification:

x && = y
x || = y
x ?? = y

Steps to Reproduce

  1. Opened https://beautifier.io/
  2. Entered the input text
  3. Clicked "Beautify Code" button

I am new to the repo but would be happy to work on this issue

mhnaeem added a commit to mhnaeem/js-beautify that referenced this issue Mar 5, 2022
mhnaeem added a commit to mhnaeem/js-beautify that referenced this issue Mar 13, 2022
@bitwiseman bitwiseman added this to the v1.15.x milestone Mar 29, 2022
@mhnaeem
Copy link
Contributor Author

mhnaeem commented Apr 6, 2022

@bitwiseman What is the process for closing issues in the project? I noticed that we released some issues but they weren't closed like this one. In addition, what is the update process for the website (https://beautifier.io/) I noticed that this issue still doesn't work on the site.

@bitwiseman bitwiseman modified the milestones: v1.15.x, v1.14.2 Apr 6, 2022
@bitwiseman
Copy link
Member

bitwiseman commented Apr 6, 2022

@mhnaeem
Thanks for calling attention to this. It looks like github pages publishing action is failing in beautifier/beautifier.io project: https://github.com/beautifier/beautifier.io/actions/runs/2059622873

I just reran it and it is working.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants