Alternative Newline Characters

[manngo]

Secondly, it appears that when jsBeautifier adds new line, it is always with the '\n' character. Is it possible to allow for the windows style '\r\n' newline? I thought I had found where the new line is created, but it seems to break the indentation. Here is what I tried:

// Somewhere around line 170:
opt.eol = options.eol ? options.eol : '\n'; // a new option

// Somewhere around line 370, change to:
if (force_newline || !just_added_newline()) {
output.push(opt.eol); // was output.push("\n");
}

… but I find that if opt.eol is anything other than '\n' all of the tabs get through away.

Thanks,

Mark

[bitwiseman]

You have a good starting idea. You need to modify just_added_newline() to check for opt.eol. There might be other gotchas but that is the first thing I can think of.

[bitwiseman]

FYI, it seems this is may not be an issue on python: jdavisclark/JsFormat#65

[bitwiseman]

Ah, and on nodejs we can use os.eol.

[jayfang]

BTW on Windows Git makes a complaint (as below) about every beautified file

warning: LF will be replaced by CRLF in myNowBeautifulFile.js.
The file will have its original line endings in your working directory.

AFAICT Git expects to see the OS eol marker. Manually resetting CRLF in my editor is fast, but it still makes beautification a bit 'noisy' in my workflow.

[bitwiseman]

Nope, that didn't work at all. This is going to be a breaking change of some kind. Pushing to next milestone.

[sethflowers]

+1 - unable to incorporate this into our teams workflow due to forcing \n as newline character.

[gabrielmaldi]

Would it be possible to release a version with this change before v1.6.0? I realize it may well be a breaking change, but I fear it will be too long until v1.6.0 is released (there are a lot of open issues) and we need this so that grunt-jsbeautifier can target it.
Thanks!

[bitwiseman]

Sure, I can do that.

[corgrath]

+1 on @gabrielmaldi 's suggestion

It would be fantastic if the eol option could come in before 1.6.0, as it is the only bug that currently breaks our code and prevents us from using grunt-jsbeautifier/jsbeautify :-)

[mahboob-awan]

@corgrath +1

[gabrielmaldi]

I've tried this new feature and it works fine 👍 However, I think I found a bug which I reported in #781.