Update js-beautify CLI options in README #1089
Conversation
|
This is a little more than what #1047 called for, but I wanted to update that section as a whole. Let me know if it's too much and I'll keep the commit limited to the |
| -s, --indent-size Indentation size [4] | ||
| -c, --indent-char Indentation character [" "] | ||
| -e, --eol character(s) to use as line terminators. (default newline - "\\n")'); | ||
| -s, --indent-size Indentation size [4] |
There was a problem hiding this comment.
How about fixing the output from --help to make this indentation even?
There was a problem hiding this comment.
Because I didn't think it was broken haha. My understanding of the pattern was a loosely tiered "match your neighbor's indentation". I take it you don't want the options under "CLI Options" to be pushed over, just those under "Beautifier Options"? I'll update it to whatever you think looks good.
There was a problem hiding this comment.
Oh whoops - I have no idea how that indentation changed. I definitely didn't do that on purpose, I'll have to check to see if my editor is being smarter than it should be.
Sorry for that
olsonpm
force-pushed
the
update-readme-cli-options
branch
from
05dbf2e
to
a48ea78
Compare
|
the indentation should be fixed with that |
http://pix.toile-libre.org/upload/original/1483098688.png That's from a fresh Should I even out the indentation in the CLI as well? |
|
@olsonpm - yes, please go ahead and even that out while you're at it. Thanks! |
olsonpm
force-pushed
the
update-readme-cli-options
branch
2 times, most recently
from
07828b8
to
90037b4
Compare
|
I'm not understanding why appveyor and travis are tripping up. Ensuring no changes visible to git have been made to '' ...
ERROR: Post-build git status check - FAILED.? |
|
Rebase your change on the latest master.
On Mon, Jan 2, 2017, 12:54 PM olsonpm <[email protected]> wrote:
I'm not understanding why appveyor and travis are tripping up.
Ensuring no changes visible to git have been made to '' ...
ERROR: Post-build git status check - FAILED.
?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1089 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AB3kKZqPe_iLX60Kd8c9YYxFgMbavzvSks5rOWPpgaJpZM4LXYDt>
.
|
olsonpm
force-pushed
the
update-readme-cli-options
branch
from
90037b4
to
e649dc1
Compare
|
Ah, I see. Run |
fixes beautifier#1047 - update cli options with exact output from `$ js-beautify --help` - even out indentation under CLI "Beautifier Options" - add missing json defaults found in the CLI - reorder json defaults to correspond with CLI output - remove 'keep_function_indentation' from documentation since it is unused - remove html beautifier specific defaults (updating that section is out of scope for this commit) - separate defaults exposed by the cli and those which aren't - reword the compatibility notice as a result of the default separation
olsonpm
force-pushed
the
update-readme-cli-options
branch
from
e649dc1
to
2dcb0fa
Compare
|
thanks |
|
@olsonpm - Thanks you! |
fixes #1047
$ js-beautify --helpscope for this commit)