Use entry_points to create script. Fix #1266 (script not working on Windows) #1455
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is cool and I'd love to merge it but my python-fu isn't strong enough. Help? |
|
Turned out the CI failed because there was a test that tried to use the "bad" script that was now removed. I would probably need to remove those tests as well. The script is only created now when an installation happens, e.g. with pip install |
|
@vivainio Is there a way to run the pip install such that the script in question gets created? |
|
Yea, 'pip install .' installs it from file system
…On Tue, 24 Jul 2018, 10:41 Liam Newman, ***@***.***> wrote:
@vivainio <https://github.com/vivainio> Is there a way to run the pip
install such that the script in question gets created?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1455 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAiCC3MkBb5ToitZ7dTcfZzUJfaOZVWrks5uJs-lgaJpZM4VZpwK>
.
|
|
That is where it installs from. We need to install it to a location where
we can check/test it.
…On Tue, Jul 24, 2018, 1:20 PM Ville Vainio ***@***.***> wrote:
Yea, 'pip install .' installs it from file system
On Tue, 24 Jul 2018, 10:41 Liam Newman, ***@***.***> wrote:
> @vivainio <https://github.com/vivainio> Is there a way to run the pip
> install such that the script in question gets created?
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <
#1455 (comment)
>,
> or mute the thread
> <
https://github.com/notifications/unsubscribe-auth/AAiCC3MkBb5ToitZ7dTcfZzUJfaOZVWrks5uJs-lgaJpZM4VZpwK
>
> .
>
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#1455 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AB3kKZ7ZRVvPHoLpXmmc0mCwojXuoNHJks5uJ4GQgaJpZM4VZpwK>
.
|
bitwiseman
force-pushed
the
master
branch
3 times, most recently
from
d2a0dc2
to
af9eecf
Compare
bitwiseman
force-pushed
the
master
branch
3 times, most recently
from
a88d0f2
to
60c3fa7
Compare
|
Fixes #1254 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.