-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
defaultOptions for js #1568
defaultOptions for js #1568
Conversation
dfd4d3c
to
88fd757
Compare
e7a4875
to
79dbee4
Compare
@zilioti Other than that this seems great. |
@zilioti |
e241b51
to
5e52800
Compare
Hi @bitwiseman, I changed the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This addresses the issue as filed.
I'll open a new issue to add a defaultOptions
to the main beautifier object in js/src/index.js
that gives a cleaned up default options object.
Hi @bitwiseman,
since I worked in the tests for options core in #1446, I decided to take a chance at doing #1364.
I opened this PR with the basic idea to check if the below implementation is desired by @tkrotoff:
Also, could you guide me where should I test? I made just a basic one for now.