Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Future contribution #1650

Closed
wants to merge 0 commits into from
Closed

Future contribution #1650

wants to merge 0 commits into from

Conversation

HanabishiRecca
Copy link
Contributor

Here will be some contribution from me :)

@HanabishiRecca
Copy link
Contributor Author

HanabishiRecca commented Mar 25, 2019 •
edited
Loading

Done #1527

@HanabishiRecca
Copy link
Contributor Author

HanabishiRecca commented Mar 28, 2019 •
edited
Loading

472ebc7 is fix for #1651

@HanabishiRecca HanabishiRecca marked this pull request as ready for review April 12, 2019 07:34
@HanabishiRecca
Copy link
Contributor Author

@bitwiseman, I think you should merge this at the current state to avoid future conflicts because of lots of changes in tests.

@bitwiseman
Copy link
Member

@HanabishiRecca
Thanks again for contributing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bitwiseman bitwiseman bitwiseman left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@HanabishiRecca @bitwiseman