Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support for logical assignment operators #1887

Closed
wants to merge 3 commits into from
Closed

support for logical assignment operators #1887

wants to merge 3 commits into from

Conversation

gilad905
Copy link

@gilad905 gilad905 commented Feb 18, 2021 •
edited by bitwiseman
Loading

support for logical OR/AND/nullish assignment operators.
(https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Operators)

Fixes #1888

@bitwiseman
Copy link
Member

bitwiseman commented Mar 1, 2021 •
edited
Loading

@gilad905
Thanks for contributing.

You need to:

  • run the build locally and get no failures or changes in the repo.
  • add tests that exercise the new functionality.
  • port the functionality to the python implementation.

bitwiseman
bitwiseman requested changes Mar 16, 2021
View reviewed changes
Copy link
Member

@bitwiseman bitwiseman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See previous comments.

@gilad905 gilad905 closed this Mar 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bitwiseman bitwiseman bitwiseman requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Logical assignment operators; Fix parsing of optional chaining
2 participants
@gilad905 @bitwiseman