Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set nodejs minimum to v14 #2169

Merged
merged 2 commits into from
Jul 24, 2023
Merged

Set nodejs minimum to v14 #2169

merged 2 commits into from
Jul 24, 2023

Conversation

bitwiseman
Copy link
Member

@bitwiseman bitwiseman commented Jul 24, 2023

See #2168. Transitive dependency commander v10.x requires nodejs v14.x.

Note, we only test on v16.x and above so this is not a guaranteed minimum.

Description

  • Source branch in your fork has meaningful name (not main)

Fixes Issue:

Before Merge Checklist

These items can be completed after PR is created.

(Check any items that are not applicable (NA) for this PR)

  • JavaScript implementation
  • Python implementation (NA if HTML beautifier)
  • Added Tests to data file(s)
  • Added command-line option(s) (NA if
  • README.md documents new feature/option(s)

See #2168.  Transitive dependency `commander v10.x` requires nodejs v14.x.
@bitwiseman bitwiseman added this to the v1.14.10 (next release) milestone Jul 24, 2023
@bitwiseman bitwiseman merged commit b7d4ac1 into main Jul 24, 2023
@bitwiseman bitwiseman deleted the bitwiseman-patch-2 branch July 24, 2023 00:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant