-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Turn new angular templating off by default in html #2247
Turn new angular templating off by default in html #2247
Conversation
with self.assertRaisesRegexp( | ||
ValueError, "Selection list cannot" + " be empty." | ||
): | ||
with self.assertRaisesRegex(ValueError, "Selection list cannot" + " be empty."): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These are aliases that were retained for backward compat to python 2.x apparently. In typical python style, they just suddenly stopped working on my system. All versions of 3 support the modern names.
@@ -4238,6 +4238,43 @@ exports.test_data = { | |||
' </div>', | |||
'}' | |||
] | |||
}, { | |||
comment: 'CSS @media should remain unchanged', | |||
// This behavior is currently incorrect. This codifies the way it fails. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is why #2219 should use a specific list of at-strings. There's just too many ways to break things otherwise.
@bitwiseman , is it possible to enable this setting currently in VSCode via |
@liesahead It looks like the settings will need to be updated to allow supplying a list of templating formatters and add I've opened microsoft/vscode-html-languageservice#177 requesting update. |
Description
main
)The new angular templating caused unintended side-effects when turned on by default. This changes it by off by default.
Fixes #2246
Before Merge Checklist
These items can be completed after PR is created.
(Check any items that are not applicable (NA) for this PR)