Minimal indenting

[bitwiseman]

This is a functional initial implementation.

I could reverse this - instead of removing redundant, under indenting and then adding missing when the first newline is added. This would produce less reprocessing of the output in most cases, but that would also make the line wrapping issue noted in #284 even more pronounced. There are simpler ways to improve this such as representing the results as an array of Line objects for quicker access to each location where fix up is needed. Or enhancing that further to have indentation represented by a number instead of characters on each Line. Then modification would be simply changing a number instead of modifying an array.

@einars , @evocateur, unless you object or have feedback, in a couple of days I'll push this change and file an issue to revisit and improve this design later.

Closes #281.

[evocateur]

This looks like a great first stab. I agree with filing an issue to improve the algorithm later, it's more important to get the functionality shipped. Thanks!

On Sun, Jun 9, 2013 at 9:09 AM, Liam Newman [email protected]
wrote:

This is a functional initial implementation.
I could reverse this - instead of removing redundant, under indenting and then adding missing when the first newline is added. This would produce less reprocessing of the output in most cases, but that would also make the line wrapping issue noted in #284 even more pronounced. There are simpler ways to improve this such as representing the results as an array of Line objects for quicker access to each location where fix up is needed. Or enhancing that further to have indentation represented by a number instead of characters on each Line. Then modification would be simply changing a number instead of modifying an array.
@einars , @evocateur, unless you object or have feedback, in a couple of days I'll push this change and file an issue to revisit and improve this design later.
Closes #281.
You can merge this Pull Request by running:
git pull https://github.com/bitwiseman/js-beautify minimal-indent
Or you can view, comment on it, or merge it online at:
#286
-- Commit Summary --

• Minimal indenting for expressions and arrays
• Allow newline preservation for function declarations
• Tests for newline preservation at close of expression
• Tweaks to recent commits
• Python parity for features in 1.3.5
  -- File Changes --
  M js/lib/beautify.js (150)
  M js/test/beautify-tests.js (80)
  M python/jsbeautifier/init.py (135)
  M python/jsbeautifier/tests/testjsbeautifier.py (91)
  -- Patch Links --
  https://github.com/einars/js-beautify/pull/286.patch
  https://github.com/einars/js-beautify/pull/286.diff

[einars]

Is leading comma intended?

[bitwiseman]

Nope, typo. Fixed.

[bitwiseman]

Oh yeah, this doesn't address #256, but it could be adapted to cover that eventually.