Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix for #722 #759

Closed
wants to merge 1 commit into from
Closed

Bugfix for #722 #759

wants to merge 1 commit into from

Conversation

corgrath
Copy link

Hey. This is a pull request to solve issue #722

I know there is a setup you need to do, that includes Python, but since I have no Python experience at all, I had problems setting the test environment up. But I saw that Travis-ci, so hopefully that can help with testing. If not, is there a chance any main developers can help verify that this fix doesn't break anything?

@corgrath
Copy link
Author

The problem is that I haven't added any new test cases to ensure this change will preserve. Is this something you can help me with?

This could be a test case:

.mixin( {
background:
red;
}
)
;

Should become

.mixin( {
    background: red;
} );

@bitwiseman
Copy link
Member

Please look at https://github.com/beautify-web/js-beautify/blob/master/test/data/css.js. Add you test using that json, then run make. This will generate tests for python and javascript.

@corgrath
Copy link
Author

I am closing this.

I cannot build the project, as I am getting problems running make in windows.

Perhaps someone else in the future has the time to create the necessary tests.

@corgrath corgrath closed this Nov 20, 2015
@bitwiseman
Copy link
Member

@corgrath - What problems are you getting building in windows?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants