Destructuring, importing, and short objects

[bitwiseman]

Fixes #114
Fixes #315
Fixes #370
Fixes #382

[ksloan]

Awesome! All praise @bitwiseman! Thanks so much for doing this. It works wonderfully.

[fyockm]

Oh happy day! Can't wait to try this out!

[underscorebrody]

@bitwiseman Thanks for doing this! It helps a lot!

One thing I'm still seeing is that this:

function something({a, b, c}, d){
  //whatever
}

is becoming this:

function something({
  a,
  b,
  c
}, d) {
  //whatever
}

This is using ES6 object destructuring in the function arguments where the desire would be for the object to stay on a single line, so I thought it might apply here. But let me know if this is a separate issue entirely. Thanks!

[bitwiseman]

@underscorebrody - No, I was expecting it to fix the input you provided. It looks like it comes out right locally. Did you turn on the new setting?

[underscorebrody]

Okay this was my fault, I ran the beautify task against some code that had been beautified already on the old version so it didn't get handled the right way. Sorry!

[bitwiseman]

@underscorebrody - No problem, thanks for jumping in and testing right away. Please report any other issues you find. 😄

[underscorebrody]

Discovered #854 while testing as well, but i don't think it's directly related to this change

[jwhitmarsh]

@bitwiseman I've just read through #114, #315, #370 and #382, and really appreciate the work you've put into supporting this!

However, with v1.6.2

import {join, other} from 'path'

// is becoming

import {
  join, other
}
from 'path';

Is that expected, or an issue with my setup?

[bitwiseman]

Probably a config issue: you need to set brace_style to collapse-preserve-inline to get the inline behavior.

https://github.com/beautify-web/js-beautify/blob/master/test/data/javascript/tests.js#L1572

[monkindey]

Thanks @bitwiseman Well done;
but is it when i type the object like

 //input
var test = {a: 1, b:2}

it did't transform to

//output
var test = {
   a: 1,
   b: 2
}

but i expect output like above

thanks your project