Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unindent-chained-methods option. resolves #482 #927

Closed
wants to merge 1 commit into from
Closed

Unindent-chained-methods option. resolves #482 #927

wants to merge 1 commit into from

Conversation

aecepoglu
Copy link
Contributor

@aecepoglu aecepoglu commented Apr 30, 2016

unindent_chained_method = true will produce this:

fun1()
.fun2();

instead of

fun1()
    .fun2();

@bitwiseman
Copy link
Member

Looks like the CI isn't updating PR statuses...

@aecepoglu
Copy link
Contributor Author

@bitwiseman I guess I'll play with my PR a bit more then. By the time the CI is up and running I'll have the same open

@aecepoglu aecepoglu closed this May 2, 2016
@bitwiseman
Copy link
Member

Okay, I've been swamped but i should have some time to look at it this week.

@brandondrew
Copy link

Excellent. Looking forward to this. Thanks for the contribution!

@aceysmith
Copy link

Bump?

@bitwiseman
Copy link
Member

I don't see a new version of this pull request.

@aecepoglu
Copy link
Contributor Author

I didn't forget about tthis. I'm just currently a bit occupied

On Wed, May 25, 2016 at 04:32:39PM -0700, Liam Newman wrote:

I don't see a new version of this pull request.


You are receiving this because you modified the open/close state.
Reply to this email directly or view it on GitHub:
#927 (comment)

@bitwiseman
Copy link
Member

@aecepoglu - believe me I know how that goes. 😄 Whenever you find opportunity.

@bitwiseman
Copy link
Member

@aecepoglu - any reason not to merge this as it was?

@aecepoglu
Copy link
Contributor Author

It doesn't remove redundant empty lines

On Fri, Jun 17, 2016 at 11:18:07AM -0700, Liam Newman wrote:

@aecepoglu - any reason not to merge this as it was?


You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub:
#927 (comment)

@pietrovismara
Copy link

+1 please!!!

@w0rp
Copy link

w0rp commented Sep 4, 2016

I'll 👍 this one too. Is there any chance this could get picked up by someone? If it works and passes all of the tests, could we merge it?

@aecepoglu
Copy link
Contributor Author

OK, I'm taking this back on. Give me a week or two and I'll have it up and running

On Sun, Sep 04, 2016 at 10:00:02AM -0700, w0rp wrote:

I'll 👍 this one too. Is there any chance this could get picked up by someone? If it works and passes all of the tests, could we merge it?

You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub:
#927 (comment)

@pietrovismara
Copy link

Almost 2 months later... :(

@w0rp
Copy link

w0rp commented Oct 26, 2016

It's funny, because in the intervening time I've actually started to up-indent my chains.

@aecepoglu
Copy link
Contributor Author

Guys, I keep telling myself I'll finish this PR and be done with it but so many things have been popping up lately that I cannot get myself to do it.

@bitwiseman
Copy link
Member

@aecepoglu - Welcome to open-source. 😄

@borwahs
Copy link

borwahs commented Jan 2, 2017

@aecepoglu - Do you have an example of the issue you described keeping this from being finished? I wouldn't mind helping out.

@aecepoglu
Copy link
Contributor Author

@borwahs Okay my memory is a little cloudy but... The problem was that when I added my change, beautification didn't delete empty lines.

I wanted to change my approach rather than do it the way I have been doing.

@bitwiseman
Copy link
Member

@borwahs @aecepoglu - Any progress on this? Just checking.

@borwahs
Copy link

borwahs commented Mar 16, 2017

@bitwiseman - my apologies! I got stuck in a project that consumed all my time (+ free time). I will try to pick this back up over the weekend.

@aiguofer
Copy link

aiguofer commented Apr 7, 2017

This would be sweet! a friend I'm working with on a project hates me because js-beautify keeps indenting chained methods and he apparently feels strongly against that.... I don't really care either way, but I just want consistent code :)

@pietrovismara
Copy link

@borwahs Man i'm seriously considering to stop using a beautifier. Please please please.

@bitwiseman
Copy link
Member

@pietrovismara - Any help you can offer is appreciated.

@dogramacigokhan
Copy link

Is there any update?

@aecepoglu
Copy link
Contributor Author

OK, ok, @bitwiseman I'm going to solve this. I'll start in an hour and not work on anything else until I solve this.

@aecepoglu
Copy link
Contributor Author

Re-opened at #1240

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants