-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unindent-chained-methods option. resolves #482 #927
Conversation
Looks like the CI isn't updating PR statuses... |
@bitwiseman I guess I'll play with my PR a bit more then. By the time the CI is up and running I'll have the same open |
Okay, I've been swamped but i should have some time to look at it this week. |
Excellent. Looking forward to this. Thanks for the contribution! |
Bump? |
I don't see a new version of this pull request. |
I didn't forget about tthis. I'm just currently a bit occupied On Wed, May 25, 2016 at 04:32:39PM -0700, Liam Newman wrote:
|
@aecepoglu - believe me I know how that goes. 😄 Whenever you find opportunity. |
@aecepoglu - any reason not to merge this as it was? |
It doesn't remove redundant empty lines On Fri, Jun 17, 2016 at 11:18:07AM -0700, Liam Newman wrote:
|
+1 please!!! |
I'll 👍 this one too. Is there any chance this could get picked up by someone? If it works and passes all of the tests, could we merge it? |
OK, I'm taking this back on. Give me a week or two and I'll have it up and running On Sun, Sep 04, 2016 at 10:00:02AM -0700, w0rp wrote:
|
Almost 2 months later... :( |
It's funny, because in the intervening time I've actually started to up-indent my chains. |
Guys, I keep telling myself I'll finish this PR and be done with it but so many things have been popping up lately that I cannot get myself to do it. |
@aecepoglu - Welcome to open-source. 😄 |
@aecepoglu - Do you have an example of the issue you described keeping this from being finished? I wouldn't mind helping out. |
@borwahs Okay my memory is a little cloudy but... The problem was that when I added my change, beautification didn't delete empty lines. I wanted to change my approach rather than do it the way I have been doing. |
@borwahs @aecepoglu - Any progress on this? Just checking. |
@bitwiseman - my apologies! I got stuck in a project that consumed all my time (+ free time). I will try to pick this back up over the weekend. |
This would be sweet! a friend I'm working with on a project hates me because js-beautify keeps indenting chained methods and he apparently feels strongly against that.... I don't really care either way, but I just want consistent code :) |
@borwahs Man i'm seriously considering to stop using a beautifier. Please please please. |
@pietrovismara - Any help you can offer is appreciated. |
Is there any update? |
OK, ok, @bitwiseman I'm going to solve this. I'll start in an hour and not work on anything else until I solve this. |
Re-opened at #1240 |
unindent_chained_method = true
will produce this:instead of