Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0] [MIG] beesdoo_product_label #520

Merged
merged 28 commits into from
Sep 14, 2023

Conversation

victor-champonnois and others added 23 commits August 2, 2023 14:04
into:
- product_main_supplier
- sale_suggested_price
- sale_adapt_price_wizard

[REF] split beesdoo_product -> product_main_supplier

[FIX] sale_suggested_price dep on product_main_supplier

[ADD] module sale_edit_price_wizard

[REF] rename sale_edit_price_wizard ->  sale_adapt_price_wizard

[REF] move rounding_method to sale_suggested_price

[REF] refactor following PR 320

[REF] search product_code -> product_main_seller

[FIX] bug adapt_sales_price

[IMP] use float_compare to compare prices

[REF] move list_price_write_date to sale_adapt_price_wizard

[FIX] beesdoo_product: main_seller_id search

[FIX] run precommit

fix
into:
- product_ingredients.
- product_hazard.
- sale_product_deposit.
- product_expiration.
- product_sale_limit_date.
- product_scale_label.
- product_barcode_generator.
- beesdoo_product_label
- product_label_print_request
Signed-off-by: Carmen Bianca BAKKER <[email protected]>
- add deposit tax group (it was originally in the wrong module)
- fix call to the consigne group
- translate the tax group to english
@victor-champonnois victor-champonnois changed the title 16.0 mig beesdoo product label [16.0] [MIG] beesdoo_product_label Aug 2, 2023
Copy link
Collaborator

@carmenbianca carmenbianca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@victor-champonnois
Copy link
Member Author

/ocabot merge nobump

@github-grap-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 16.0-ocabot-merge-pr-520-by-victor-champonnois-bump-nobump, awaiting test results.

github-grap-bot added a commit that referenced this pull request Sep 14, 2023
Signed-off-by victor-champonnois
@github-grap-bot
Copy link
Contributor

@victor-champonnois your merge command was aborted due to failed check(s), which you can inspect on this commit of 16.0-ocabot-merge-pr-520-by-victor-champonnois-bump-nobump.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

@victor-champonnois
Copy link
Member Author

/ocabot merge nobump

@github-grap-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 16.0-ocabot-merge-pr-520-by-victor-champonnois-bump-nobump, awaiting test results.

@github-grap-bot github-grap-bot merged commit a348281 into 16.0 Sep 14, 2023
2 checks passed
@github-grap-bot
Copy link
Contributor

Congratulations, your PR was merged at 4803b52. Thanks a lot for contributing to beescoop. ❤️

@github-grap-bot github-grap-bot deleted the 16.0-mig-beesdoo_product_label branch September 14, 2023 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants