-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
16.0 mig cooperator worker #528
Conversation
097eea5
to
7f1a73a
Compare
Codecov Report
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. @@ Coverage Diff @@
## 16.0-mig-eater #528 +/- ##
==================================================
+ Coverage 67.58% 68.70% +1.12%
==================================================
Files 53 60 +7
Lines 1672 1748 +76
Branches 230 236 +6
==================================================
+ Hits 1130 1201 +71
- Misses 500 502 +2
- Partials 42 45 +3
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly LGTM, some comments.
In the future, it's easier (and standard OCA process) to create a separate migration commit for every version through which you are migrating. You don't need to test every version; the process is a development aid and helps future Git archaeologists figure out why some changes were made.
test-requirements.txt
Outdated
@@ -0,0 +1 @@ | |||
git+https://github.com/coopiteasy/[email protected]#subdirectory=setup/cooperator |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Make sure to delete this commit before merging.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@carmenbianca are you sure I should remove this commit before merging ? The corresponding PR is still open OCA/cooperative#86
(test-requirements here was updated)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you want this merged sooner rather than later, it's OK to merge as-is. I didn't realise this wasn't an OCA repo.
It's still not ideal (we have to remember to remove that line again), but it'll do.
So if I understand correctly, here, I should do
Correct ? |
7f1a73a
to
4c3f945
Compare
4c3f945
to
73ede91
Compare
[REF] Split beesdoo_emc -> cooperator_worker_configuration [ADD] migration script [UPD] Update cooperator_worker_configuration.pot [REF] split beesdoo_emc -> cooperator_eater_configuration [UPD] Update cooperator_eater_configuration.pot [REF] beesdoo_emc -> cooperator_info_session [UPD] Update cooperator_info_session.pot [REM] auto-install [IMP] cooperator_worker_configuration: add help message on is_worker
auto_install was added during the migration. It is a regression both cooperator and beesdoo_shift modules can be used separatly. Making the link is a choice by the user.
Signed-off-by: Carmen Bianca BAKKER <[email protected]>
increment versions of dependent modules after renaming of beesdoo_shift and beesdoo_worker_status.
0e7f62b
to
c1c0ca8
Compare
4cc5ec5
to
eac94d1
Compare
Basically yes @ your question on commits. |
/ocabot merge nobump |
Hey, thanks for contributing! Proceeding to merge this for you. |
Congratulations, your PR was merged at 913f549. Thanks a lot for contributing to beescoop. ❤️ |
functionaly tested on 16-test-cooperator
As is : As long as a partner who is a cooperator doesn't have a working mode, @carmenbianca I created an internal task to improve this. |
Also @carmenbianca I realise that this module is really a |
Description
Odoo task (if applicable)
https://gestion.coopiteasy.be/web#id=10786&action=475&active_id=469&model=project.task&view_type=form&menu_id=536
Checklist before approval