Skip to content

Commit

Permalink
Adapt to some recent flake8/pycodestyle changes
Browse files Browse the repository at this point in the history
As surfaced in this CI run:
https://github.com/beetbox/beets/actions/runs/5716141601/job/15486984755?pr=4866

These all look like perfectly reasonable improvements that are unlikely
to break anything.
  • Loading branch information
sampsyo committed Jul 31, 2023
1 parent e18b943 commit 7f7db33
Show file tree
Hide file tree
Showing 4 changed files with 7 additions and 7 deletions.
2 changes: 1 addition & 1 deletion beets/autotag/hooks.py
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
from collections import namedtuple
from functools import total_ordering
import re
from typing import Dict, List, Tuple, Iterator, Union, Any, Optional,\
from typing import Dict, List, Tuple, Iterator, Union, Any, Optional, \
Iterable, Callable, cast

from beets import logging
Expand Down
6 changes: 3 additions & 3 deletions beets/dbcore/query.py
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,7 @@ def __repr__(self) -> str:
return f"{self.__class__.__name__}()"

def __eq__(self, other) -> bool:
return type(self) == type(other)
return type(self) is type(other)

def __hash__(self) -> int:
"""Minimalistic default implementation of a hash.
Expand Down Expand Up @@ -868,7 +868,7 @@ def __hash__(self) -> int:
return 0

def __eq__(self, other) -> bool:
return type(self) == type(other)
return type(self) is type(other)


class MultipleSort(Sort):
Expand Down Expand Up @@ -1014,7 +1014,7 @@ def __bool__(self) -> bool:
return False

def __eq__(self, other) -> bool:
return type(self) == type(other) or other is None
return type(self) is type(other) or other is None

def __hash__(self) -> int:
return 0
2 changes: 1 addition & 1 deletion beets/importer.py
Original file line number Diff line number Diff line change
Expand Up @@ -1363,7 +1363,7 @@ def _freshen_items(items):

def _extend_pipeline(tasks, *stages):
# Return pipeline extension for stages with list of tasks
if type(tasks) == list:
if type(tasks) is list:
task_iter = iter(tasks)
else:
task_iter = tasks
Expand Down
4 changes: 2 additions & 2 deletions beetsplug/acousticbrainz.py
Original file line number Diff line number Diff line change
Expand Up @@ -323,11 +323,11 @@ def _data_to_scheme_child(self, subdata, subscheme, composites):
"""
for k, v in subscheme.items():
if k in subdata:
if type(v) == dict:
if isinstance(v, dict):
yield from self._data_to_scheme_child(subdata[k],
v,
composites)
elif type(v) == tuple:
elif isinstance(v, tuple):
composite_attribute, part_number = v
attribute_parts = composites[composite_attribute]
# Parts are not guaranteed to be inserted in order
Expand Down

0 comments on commit 7f7db33

Please sign in to comment.