Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

badfiles: silent mode #1654

Closed
Kernald opened this issue Oct 21, 2015 · 6 comments
Closed

badfiles: silent mode #1654

Kernald opened this issue Oct 21, 2015 · 6 comments
Labels
feature features we would like to implement good first issue https://github.com/beetbox/beets/pull/5479

Comments

@Kernald
Copy link
Contributor

Kernald commented Oct 21, 2015

Running the badfiles plugin on an entire collection is pretty much unreadable for now. It would be great to have different levels of verbosity:

  • display all
  • display only bad files
  • display nothing (just a return code).
@sampsyo sampsyo added the feature features we would like to implement label Oct 21, 2015
@sampsyo
Copy link
Member

sampsyo commented Oct 21, 2015

Sounds good. In fact, I'd argue that "show bad files only" should be the default mode.

@Kolbasz12
Copy link

2 cents, if showing bad files only, does this mean files with "garbage at beginning/end of file"

This seems fairly common on some media so it could still be a lot of files. I would argue to add option to fix files and then display only ones bad after a failed fix maybe. I dont know, could be off topic for the OP

@sampsyo sampsyo added the good first issue https://github.com/beetbox/beets/pull/5479 label Jan 26, 2016
@ghost
Copy link

ghost commented Jan 29, 2016

Hey guys, we would like to tackle this issue, if anyone is going to work on this soon let me know so we can look at other issues! We're planning to start working on this on Monday February 1st. Thanks! -Jake

@fxthomas
Copy link
Contributor

I was planning on doing this but I don't have much time to hack on beets at the moment. You're good to go!

@SpirosChadoulos
Copy link
Contributor

Greetings..I was thinking about tackling this issue but then I noticed tha some changes were made to the badfiles plugin. Does this mean this issue should be closed or shall I tackle it?

@sampsyo
Copy link
Member

sampsyo commented Apr 8, 2017

Oh yeah, thanks! Looks like this was fixed in #2434.

@sampsyo sampsyo closed this as completed Apr 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature features we would like to implement good first issue https://github.com/beetbox/beets/pull/5479
Projects
None yet
Development

No branches or pull requests

5 participants