Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A few changes to the badfiles plugin #2432

Closed
wants to merge 5 commits into from

Conversation

karpinski
Copy link
Contributor

Adding a verbosity option per request from #1654.

Process now continues to other files instead of stopping after a checker error (#2430).

The checker errors are logged only once for each file extension by default and for each file separately in the verbose mode. Let me know if this is fine or if you'd rather have just one of those.

@sampsyo
Copy link
Member

sampsyo commented Feb 9, 2017

Thanks for getting this started!

Is there any chance I could convince you to break this out into two separate PRs? The discussion here might get a little bit messy otherwise. It's possible we can resolve everything easily, of course, but if not, it might be nice to have two separate discussions.

For the verbosity mode: beets already has a global verbosity mode, which affects the logging level. Can we just use that judiciously instead of introducing a new flag? That would just mean sending everything to debug output except for the important messages.

For the new exception handling, throwing a new exception is fine. But it seems like an easier implementation here would just log a message and continue—that would be a bit simpler than building up a list of missing checkers. I know that will make the output more verbose, but I also think it will be slightly less surprising to use. Does that make sense?

@karpinski
Copy link
Contributor Author

Thanks for the feedback, @sampsyo! I've opened new PRs for those separate changes.

@karpinski karpinski closed this Feb 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants