-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lyrics plugin crashing on tekstowo.pl #3904
Comments
Paging @xhocquet, as per the other issue. |
Looking! |
The error is still happening with the new version. |
@njelich Would you mind giving me a specific track this is failing for? |
I submitted an example earlier, the temp.txt file is the html excrept that the error occured on with the .find function. I also noticed that the lyrics that do go through have "Tekst piosenki:" at the top and ""Historia edycji tekstu" at the bottom. I don't think the commit done does anything that has to do with the actual issue I submitted. I'm taking a look myself as well, but I haven't worked with beautifulSoup yet. |
@njelich After parsing out your txt file to find the track/artist, Capitalist Casualties - Gig Violence, I was not able to reproduce your issue with the latest code (ignore the 'eye' piece of the file tags, I use that for convenience when I was testing other files but it is not used in the lyrics search):
Lyrics search executes as expected without error and saves the lyrics to the file. If this is still an issue, can you please provide more information like the commands used, the stack of the issue, etc.? cc @sampsyo |
I just found it crashing while searching tekstowo.pl (I'm on afc0728).
These are the relevant lines of error.
I also printed the html to the console, but I am unsure why the error is appearing. The div with the class song-text seems to exist and I've never worked on beets before. Could it have something to do with there being two divs with the class?
I uploaded the html, but had to do it with txt extension due to GitHub limitations.
temp.txt
Originally posted by @njelich in #3903 (comment)
The text was updated successfully, but these errors were encountered: