lyrics: Polish comments appear in text of lyrics

[mattmartini]

When downloading lyrics for songs there is Polish text appearing at the top and bottom of the text. This text is saved into the mp3. It seems like this should be resolved with something like the remove_credits() function.

When lyrics are downloaded the text

Tekst piosenki:

appears at the top of the lyrics. [Translates to "lyrics"]

Additionally, the text

Dodaj interpretację do tego tekstu »

Historia edycji tekstu

appears at the bottom of the text. [Translates to "add interpretation to this text" and "history of the text editing"]

This appears on every lyrics downloaded.

This was mentioned in issues #3904 and #4043 as side issues, but since it was never fixed I am opening this issue in hopes that it will be addressed.

Problem

Running this command in verbose (-vv) mode:

$ beet -vv lyrics -p Papercut
user configuration: /home/<USER>/.config/beets/config.yaml
data directory: /home/<USER>/.config/beets
plugin paths:
ImageMagick version check failed: [Errno 2] No such file or directory: 'magick': 'magick'
artresizer: method is (2, (6, 9, 7), True)
lyrics: Disabling google source: no API key configured.
lastgenre: Loading canonicalization tree /home/<USER>/.local/lib/python3.6/site-packages/beetsplug/lastgenre/genres-tree.yaml
Sending event: pluginload
library database: /media/audio/DBs/beets_musiclibrary.db
library directory: /media/audio/Music_Collection
Sending event: library_opened
lyrics: lyrics already present: AAC 256kbps  2:36  02/06  Rap	JAY‐Z & Linkin Park	2004Collision Course	Big Pimpin’ / Papercut
Tekst piosenki:
Hahaha, wasting your talent Randy!
Yeah, you're ready?

[SNIP - full text of lyrics removed for brevity]

We doin'... big pimpin' up in N.Y.C.
It's just that Jigga Man, Pimp C, and B.U.N.B-B-B
Dodaj interpretację do tego tekstu »

Historia edycji tekstu
Sending event: cli_exit

Led to this problem:

Extraneous lines in lyrics text:

Tekst piosenki:
Dodaj interpretację do tego tekstu »
Historia edycji tekstu

Here's a link to the music files that trigger the bug (if relevant):

It happens with every music file.

Setup

This happens on both Mac and Linux computers:

* OS: Mac OS 10.14.6 (Mojave)
* Python version: 3.9.8
* beets version: 1.6.0
* Turning off plugins made problem go away (yes/no): no, it is a plugin issue

* OS: Linux Ubuntu 18.04.6 LTS (Bionic Beaver)
* Python version: 3.6.9
* beets version: 1.6.0
* Turning off plugins made problem go away (yes/no): no, it is a plugin issue

My configuration (output of beet config) is:

lyrics:
    bing_lang_from: []
    auto: no
    force: no
    bing_client_secret: REDACTED
    bing_lang_to:
    google_API_key: REDACTED
    google_engine_ID: REDACTED
    genius_api_key: REDACTED
    fallback:
    local: no
    sources:
    - google
    - musixmatch
    - genius
    - tekstowo

[sampsyo]

Thanks for the detailed report; this is super helpful!

[hlubach]

beets version 1.6.0
Python version 3.8.10
plugins: convert, discogs, duplicates, embedart, fetchart, ftintitle, info, lastgenre, lyrics, missing, permissions, scrub, zero
Just tried beet lyrics -f yesterday.
But when going through the Library still in some songs the Polish lyrics.

Tekst piosenki:

appears at the top of the lyrics. [Translates to "lyrics"]

Additionally, the text

Dodaj interpretację do tego tekstu »

Historia edycji tekstu

appears at the bottom of the text. [Translates to "add interpretation to this text" and "history of the text editing"]

It seems that this item is still not solved

[sampsyo]

To confirm, are you running the latest source version of beets?

[hlubach]

***@***.***:~$ apt-get install python-dev python-pip E: Kon het vergrendelingsbestand /var/lib/dpkg/lock-frontend niet openen - open (13: Toegang geweigerd) E: Kan de vergrendeling voor het dpkg-frontend (/var/lib/dpkg/lock-frontend) niet verkrijgen. Heeft u beheerdersrechten? ***@***.***:~$ sudo apt-get install python-dev python-pip [sudo] wachtwoord voor han: Pakketlijsten worden ingelezen... Klaar Boom van vereisten wordt opgebouwd De statusinformatie wordt gelezen... Klaar Let op, 'python-dev-is-python2' wordt geselecteerd in plaats van 'python-dev' Pakket python-pip is niet beschikbaar, hoewel er naar verwezen wordt door een ander pakket. Mogelijk betekent dit dat het pakket ontbreekt, verouderd is, of enkel beschikbaar is van een andere bron Echter, de volgende pakketten vervangen dit: python3-pip E: Pakket 'python-pip' heeft geen kandidaat voor installatie beets version 1.6.0 Python version 3.8.10 plugins: convert, discogs, duplicates, embedart, fetchart, ftintitle, info, lastgenre, lyrics, missing, permissions, scrub, zero han "Adrian Sampson" ***@***.*** ***@***.******@***.***>)> schreef op 31 maart 2022 21:23: To confirm, are you running the latest source version of beets? — Reply to this email directly, view it on GitHub (#4228 (comment)), or unsubscribe (https://github.com/notifications/unsubscribe-auth/AB344IEF4CK7NGOEQYQOSODVCX3R5ANCNFSM5LT33OWQ). You are receiving this because you commented.Message ID: ***@***.***>

[wisp3rwind]

That's probably the same thing that makes our weekly integration tests fail, cf. e.g. https://github.com/beetbox/beets/actions/runs/2046155673

The Tekstowo source needs to be fixed; I guess they updated their website structure at some point and our scraper now picks up extraneous text?

[sampsyo]

Indeed; looks like it. Maybe this needs a new issue?

[hlubach]

The last thing I did was the next command the best way to upgrade beets to a new version is by running pip install -U beets. You may want to follow @b33ts (https://twitter.com/b33ts) on Twitter to hear about progress on new versions. Do not know or did is what you mean with the latest source version "Adrian Sampson" ***@***.*** ***@***.******@***.***>)> schreef op 31 maart 2022 21:23: To confirm, are you running the latest source version of beets? — Reply to this email directly, view it on GitHub (#4228 (comment)), or unsubscribe (https://github.com/notifications/unsubscribe-auth/AB344IEF4CK7NGOEQYQOSODVCX3R5ANCNFSM5LT33OWQ). You are receiving this because you commented.Message ID: ***@***.***>