Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tekstowo lyrics source needs to be adapted to new website layout #4334

Closed
wisp3rwind opened this issue Apr 16, 2022 · 2 comments · Fixed by #4344
Closed

Tekstowo lyrics source needs to be adapted to new website layout #4334

wisp3rwind opened this issue Apr 16, 2022 · 2 comments · Fixed by #4344
Labels
bug bugs that are confirmed and actionable

Comments

@wisp3rwind
Copy link
Member

From #4228

That's probably the same thing that makes our weekly integration tests fail, cf. e.g. https://github.com/beetbox/beets/actions/runs/2046155673

The Tekstowo source needs to be fixed; I guess they updated their website structure at some point and our scraper now picks up extraneous text?

Originally posted by @wisp3rwind in #4228 (comment)

@wisp3rwind wisp3rwind added the bug bugs that are confirmed and actionable label Apr 16, 2022
@qcasey
Copy link
Contributor

qcasey commented May 5, 2022

Googling this issue brought me here. I think this was fixed in 3f896ab? I use Tekstowo a lot.

beets 1.6.0

Tracks with extraneous text:

$ beet stats "lyrics:Tekst piosenki:" 
Tracks: 2716
Total time: 1.1 weeks
Approximate total size: 14.2 GiB
Artists: 988
Albums: 562
Album artists: 531

beets master/1.6.1

Switched to the git version of beets:

pip3 install git+https://github.com/beetbox/beets

Reran lyrics on tracks with extraneous text:

beet lyrics "lyrics:Tekst piosenki:"

Lyrics look right now.

$ beet stats "lyrics:Tekst piosenki:"
Tracks: 0
Total time: 0.0 seconds
Approximate total size: 0.0 B
Artists: 0
Albums: 0
Album artists: 0

@wisp3rwind
Copy link
Member Author

See #4344: Probably there's no issue, but a report based on an old version of beets. Feel free to re-open or create a new issue if this is not true.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug bugs that are confirmed and actionable
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants