badfiles: continue execution to other files instead of stopping after a checker error #2433
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sampsyo
requested changes
Feb 9, 2017
| if status > 0: | ||
| ui.print_(u"{}: checker exited withs status {}" | ||
| ui.print_(u"{}: checker exited with status {}" |
| @@ -97,14 +102,25 @@ def check_bad(self, lib, opts, args): | |||
| ext = os.path.splitext(item.path)[1][1:].decode('utf8', 'ignore') | |||
| checker = self.get_checker(ext) | |||
| if not checker: | |||
| self._log.debug(u"no checker available for {}", ext) | |||
| self._log.error(u"no checker specified in the config for {}", | |||
| ext) | |||
There was a problem hiding this comment.
Great; this is indeed a better message.
beetsplug/badfiles.py
Outdated
| self._log.error( | ||
| u"command not found: {} when validating file: {}", | ||
| e.checker, | ||
| e.path) |
There was a problem hiding this comment.
I think Travis is complaining about the indentation here. The indented lines should just be one "tab" (4 spaces) indented, and the closing parenthesis should be on a line by itself (not indented).
beetsplug/badfiles.py
Outdated
| @@ -30,6 +30,16 @@ | |||
| import six | |||
|
|
|||
|
|
|||
| class CheckerCommandException(Exception): | |||
| """Raised when running a Checker failed.""" | |||
There was a problem hiding this comment.
Could you please expand the docstring just a little to explain what the fields mean (checker, path, errno, and msg)?
karpinski
force-pushed
the
badfiles-checkers
branch
from
ac5ea89
to
b46fb95
Compare
sampsyo
added a commit
that referenced
this pull request
Feb 12, 2017
badfiles: continue execution to other files instead of stopping after a checker error
sampsyo
added a commit
that referenced
this pull request
Feb 12, 2017
sampsyo
added a commit
that referenced
this pull request
Feb 12, 2017
|
Thank you for taking care of this so quickly! It's all merged up. ✨ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#2430