Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mbcollection: Support specifiying collection ID. #2685

Merged
merged 3 commits into from
Sep 10, 2017
Merged

Conversation

djl
Copy link
Member

@djl djl commented Sep 9, 2017

For those of us who have multiple MusicBrainz collections I've added support for specifying which collection you'd like to use.

In the future I'd like to add support for multiple collections updated via queries (in the vein of the smartplaylist plugin).

@mention-bot
Copy link

@djl, thanks for your PR! By analyzing the history of the files in this pull request, we identified @sampsyo, @pkess and @brunal to be potential reviewers.

@sampsyo
Copy link
Member

sampsyo commented Sep 10, 2017

This is perfect! Thanks for the refactoring—I like the new method too.

A “smart playlist” feature for collections could be cool too...

@sampsyo sampsyo merged commit cdd4402 into master Sep 10, 2017
@djl djl deleted the mbc-customids branch September 10, 2017 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants