mediafile._safe_cast: be safer when converting to int #2741
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks great; thank you for catching this! Would you mind writing a changelog entry describing what could go wrong (i.e., a ValueError would occur when a number was just + or just -)? |
The regex «[\+-]?[0-9]*» possibly matches a single minus/plus, which would then be passed on to int(), raising a ValueError from within _safe_cast. The test suite covered this for float, but not for int. We now make sure we actually have a number after the sign by using a Kleene plus.
|
Thanks! Amended. |
sampsyo
added a commit
that referenced
this pull request
Nov 19, 2017
mediafile._safe_cast: be safer when converting to int
|
Thanks again!! I've merged the fix. |
|
Thank you for making beets! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The regex «[+-]?[0-9]*» possibly matches a single minus/plus, which was then
passed on to int, raising a ValueError from within _safe_cast. The test suite
covered this for float, but not for int.
We now make sure we actually have a number after the sign by using a Kleene
plus.