First tentative fix for issue 2738. #2759
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Don't ignore anymore filenames such as "01.mp3", instead use the number in the filename as track number.
|
Hi! Sorry for the delay in reviewing this, but it looks perfect! Would you mind adding a brief changelog entry about the new capability? Then this should be ready to merge as-is, if it's been working for you. ✨ |
Some more changes to the regular expressions in the "PATTERNS" list. Also allow "_" as a separator, where only "-" was allowed. Replaced similar regexps containing different combinations of \s, "-", "." with a single regexp using a set of characters [\s.\-_].
…/beets into 2738-filename-tracknumber
|
Ok, I've added a changelog entry (and fixed a conflict, since my branch was a bit old), did some more fixes to the regular expressions (see commit message 84cf336 ), fixed a line-too-long. |
sampsyo
added a commit
that referenced
this pull request
Dec 21, 2017
First tentative fix for issue 2738.
sampsyo
added a commit
that referenced
this pull request
Dec 21, 2017
|
Perfect! Thank you for the updates, and for the clean fix for this shortcoming. ✨ Woohoo! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't ignore anymore filenames such as "01.mp3", instead use the number
in the filename as track number.