-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bpd: support idle command and with it MPD 0.14 #3205
Merged
Merged
Commits on Apr 8, 2019
-
Configuration menu - View commit details
-
Copy full SHA for f8a2c22 - Browse repository at this point
Copy the full SHA f8a2c22View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5b0a02e - Browse repository at this point
Copy the full SHA 5b0a02eView commit details -
bpd: track and log client session details
Keep track of a list of currently-connected clients. Use `socket.getpeername()` to get an identifier for each connection and include this in each log message. This function is documented as not being available on all systems, but it's unclear which systems this involves. Also log a message on client connect and disconnect events. If the disconnection reason is because the client sent a blank line, match MPD by returning a protocol error then hanging up. Escape curly braces.
Configuration menu - View commit details
-
Copy full SHA for ee0c31b - Browse repository at this point
Copy the full SHA ee0c31bView commit details -
bpd: implement the idle command
Getting this command puts the connection into a special mode where it awaits MPD events (like the player changing state or the playlist changing due to other clients interacting with the server. The MPD specification states that events should queue while a client is connected, and when it issues the `idle` command any matching events should be sent immediately if there are any, or as soon as they happen otherwise.
Configuration menu - View commit details
-
Copy full SHA for 7105c80 - Browse repository at this point
Copy the full SHA 7105c80View commit details -
Configuration menu - View commit details
-
Copy full SHA for 699de94 - Browse repository at this point
Copy the full SHA 699de94View commit details -
Configuration menu - View commit details
-
Copy full SHA for d05ca2c - Browse repository at this point
Copy the full SHA d05ca2cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 6fbf385 - Browse repository at this point
Copy the full SHA 6fbf385View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2753017 - Browse repository at this point
Copy the full SHA 2753017View commit details -
Configuration menu - View commit details
-
Copy full SHA for e70b213 - Browse repository at this point
Copy the full SHA e70b213View commit details -
Configuration menu - View commit details
-
Copy full SHA for fa38138 - Browse repository at this point
Copy the full SHA fa38138View commit details
Commits on Apr 9, 2019
-
A new `ControlConnection` is created each time a client connects over a new control socket. This is used to forward events from the player, and also for debugging utilities that are not part of the real MPD protocol. This new feature reuses as much infrastructure from the normal protocol handling as possible (e.g. `Command` for parsing messages). While the normal connection delegates to server `cmd_*` methods which are string generators, the control connections delegate to `ctrl_*` methods defined on the connection itself that are full coroutines.
Configuration menu - View commit details
-
Copy full SHA for d55f061 - Browse repository at this point
Copy the full SHA d55f061View commit details
Commits on Apr 10, 2019
-
Configuration menu - View commit details
-
Copy full SHA for 8262447 - Browse repository at this point
Copy the full SHA 8262447View commit details -
Configuration menu - View commit details
-
Copy full SHA for 241e23e - Browse repository at this point
Copy the full SHA 241e23eView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.