-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #2080 #3372
Fix #2080 #3372
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks wonderful; thank you!! Really nice work on this.
I just have one small suggestion for the docs.
The tests revealed that we might need to add Those are listed in our Tox config: Lines 13 to 26 in 3ffd5ca
|
Ah, I have thought before that the |
Perfect! Let me re-emphasize that we really appreciate your adding such extensive tests for the plugin. Wahoo! |
@temrix i just updated my beets install and i tried to import a test dir with few tracks and i get the following error:
|
Can you open a new issue with this? We can discuss there. And try to pin-point the track or at least a range of albums the error has occurred with. |
This fixes feature request #2080 .
I have added
bpm
,musical_key
andgenre
in the beatport plugin. I needed to modify the hooks in the autotagger to accept those additional attributes.genre
will be fetched for each track. I have also added a test file to test the plugin.