-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
discogs: Add index_tracks
option (closes #3458)
#3459
Conversation
index_tracks
option (#3458)index_tracks
option (closes #3458)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! I have a couple of tiny suggestions above. Also, would you mind adding a quick changelog entry describing the new option?
Co-Authored-By: Adrian Sampson <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks wonderful; thanks!!
This PR implements the feature described in #3458, enabled with the
index_tracks
option in thediscogs:
section.Since
DiscogsPlugin.coalesce_tracks
discards index tracks that are used to title subtrack mergers, I don't think it interacts badly with this feature. But I might be missing something, in which case please correct me.