Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

discogs: Add index_tracks option (closes #3458) #3459

Merged
merged 13 commits into from
Dec 18, 2019

Conversation

cole-miller
Copy link
Contributor

@cole-miller cole-miller commented Dec 17, 2019

This PR implements the feature described in #3458, enabled with the index_tracks option in the discogs: section.

Since DiscogsPlugin.coalesce_tracks discards index tracks that are used to title subtrack mergers, I don't think it interacts badly with this feature. But I might be missing something, in which case please correct me.

@cole-miller cole-miller changed the title discogs: Add index_tracks option (#3458) discogs: Add index_tracks option (closes #3458) Dec 17, 2019
@cole-miller cole-miller marked this pull request as ready for review December 17, 2019 23:48
Copy link
Member

@sampsyo sampsyo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! I have a couple of tiny suggestions above. Also, would you mind adding a quick changelog entry describing the new option?

beetsplug/discogs.py Show resolved Hide resolved
beetsplug/discogs.py Outdated Show resolved Hide resolved
Copy link
Member

@sampsyo sampsyo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks wonderful; thanks!!

@sampsyo sampsyo merged commit a9b19e1 into beetbox:master Dec 18, 2019
@cole-miller cole-miller deleted the index-tracks branch December 19, 2019 01:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants