Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add additional asciify documentation #4067

Merged
merged 1 commit into from
Sep 18, 2021
Merged

Conversation

emiham
Copy link
Contributor

@emiham emiham commented Sep 18, 2021

Description

Fixes #929.

This was proposed but never dealt with, so after going through some confusion around this myself I figured it's about time.

To Do

  • Documentation. (If you've add a new command-line flag, for example, find the appropriate page under docs/ to describe it.)
  • Changelog. (Add an entry to docs/changelog.rst near the top of the document.)
  • Tests. (Encouraged but not strictly required.)

This was proposed in beetbox#929 but never dealt with, so after going through some confusion around this myself I figured it's about time.
@sampsyo
Copy link
Member

sampsyo commented Sep 18, 2021

Awesome; this will be helpful, I think! Thanks for adding it.

@sampsyo sampsyo merged commit dd711c0 into beetbox:master Sep 18, 2021
arogl added a commit to arogl/beets that referenced this pull request Sep 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

More 'asciify' documentation
2 participants