Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added notes about MacPorts #4069

Merged
merged 5 commits into from
Sep 22, 2021
Merged

Added notes about MacPorts #4069

merged 5 commits into from
Sep 22, 2021

Conversation

catap
Copy link
Contributor

@catap catap commented Sep 21, 2021

No description provided.

@catap
Copy link
Contributor Author

catap commented Sep 21, 2021

@sampsyo I feel that you defently would like to adjust wording :)

Copy link
Member

@sampsyo sampsyo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!! Indeed; here are a couple of comments.

Python yourself with `Homebrew`_ or otherwise.)
some parts of the system. This means that some ``pip`` commands may fail with a
permissions error. (You probably *won't* run into this if you've installed
Python yourself with `Homebrew`_ or otherwise. Or use `MacPorts`_)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Python yourself with `Homebrew`_ or otherwise. Or use `MacPorts`_)
Python yourself with `Homebrew`_ or otherwise. You can also try `MacPorts`_.)

Comment on lines 15 to 19
* On **macOS**, there's a `MacPorts`_ port. Just run ``port install beets`` or
``port install beets-full`` to install it with all 3rd party plugins. macOS**
11 (Big Sur) includes Python 3.8 out of the box and you may install it via
``pip``. You can opt for a more recent Python installing it via `Homebrew`_:
``brew install python3`` for older versions.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good, but let's keep the Homebrew thing first… that is, list the text beginning "11 (BigSur) includes…" first. Then, the next sentence can say, like, "There's also a MacPorts port. Just run…"

Also, I'm not entirely sure what "all 3rd party plugins" means… there are a lot of third-party plugins out there! Do you mean all dependencies for the included (first-party) plugins, perhaps?

Copy link
Contributor Author

@catap catap Sep 21, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sampsyo I mean that almost all plugins from Other Plugins are included as dedicated port and beets-full installs all of them. With all dependencies. Technically speaking I've added 25 ports which include 22 3rd party plugins,beets, beets-devel (the master branch) and beets-full (install everything).

I've done it because I'm using some of this plugins, and it seems fair to package them all. Special that adding them wasn't so hard. Ok, adding all python dependencies was, but it is another story :)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Incredible! Well, maybe I'd just say "lots of third-party plugins" or something to sidestep the potential confusion around claiming "all". 😃

@sampsyo
Copy link
Member

sampsyo commented Sep 22, 2021

Tweaked it a bit more for concision, but looks good! Thanks again!

@sampsyo sampsyo merged commit 7ae8b9c into beetbox:master Sep 22, 2021
@catap catap deleted the macports-note branch September 22, 2021 15:09
arogl added a commit to arogl/beets that referenced this pull request Sep 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants