Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: add a (xfailing) test for issue #4528 #4586

Merged
merged 1 commit into from
Dec 18, 2022

Conversation

wisp3rwind
Copy link
Member

From #4582 (@jpluscplusm)

I strongly suggest that this only be merged after tests are added that would have caught this problem before 1.6.0 was released. I've added no tests in this PR as the relevant parts of the Beets test suite quickly put me out of my depth. I really think it's worth getting a failing test in place, before merging this (I'll happily rebase, or anything else needed) as I /believe/ this bug will be causing any Beets user on 1.6.0+ to be re-tagging much/all of their library on each write.

This PR should do the trick.

I'm not up to speed on the issue and the history of the albumtype[s] fields, this is only a quick test made from the description of the problem. So, I can't really comment on the solution and an automated database fix that the next beets version might do. I do feel urged to point out that the interaction between the albumtype and albumtypes fields is completely unclear to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant