test_ui: Fix spurious warnings in completion test #4829
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
probably an issue going back to the Python 2 -> 3 switch: `map` gives an iterator nowadays so after the test case started iterating BASH_COMPLETION_PATHS, print_completion() couldn't find the (previously found) bash_completion anymore, and would log a spurious warning about that. Also, some cleaup of path type handling
wisp3rwind
force-pushed
the
fix_completion_test
branch
from
7a279fb
to
26faf8d
Compare
sampsyo
approved these changes
Jun 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some reason, the completion test is always failing for me locally. While this PR doesn't actually fix that; at least it removes a spurious warning.