Always use syspath conversions (#3690 split up, part 1) #4830
Conversation
wisp3rwind
force-pushed
the
pr_add_syspath_1
branch
3 times, most recently
from
446dff0
to
3dc981a
Compare
these are mostly in the tests, which didn't cause issues since the affected directories usually have nice ASCII paths. For consistency, it is nicer to always invoke syspath. That also avoids deprecation warnings for the bytestring interfaces on Python <= 3.5. The bytestring interfaces were undeprecated with PEP 529 in Python 3.6, such that we didn't observe any actual failures.
wisp3rwind
force-pushed
the
pr_add_syspath_1
branch
from
3dc981a
to
1ef6b90
Compare
There was a problem hiding this comment.
Awesome; thanks for splitting this off. There are obviously a lot of lines in the diff, but I scanned over everything and it checks out at a glance.
The one weird thing in here is the identification of some trouble with the thumbnails plugin. That plugin is a surprisingly complicated bugaboo relative to how simple (and perhaps how widely used) it is; it could certainly use an overhaul but may not have enough users to have anyone interested in doing it.
I haven't looked at the thumbnails plugin recently; so can't really tell anything about it's state. However, once I wrap up the rest of #3690, the path handling should hopefully be addressed. |
I've had #3690 in the pipeline for a long time; and it has grown too big to look at in one piece. This is just the first commit rebased on master. It is still quite big, but only touches test code, so should be safe (assuming CI is green).