-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add advanced rewrite plugin #4845
Conversation
6e66b2d
to
3bc2376
Compare
Just trying to understand...how is this different than |
Very interesting; thanks for getting this started! In addition to @arsaboo's question, I'd also be interested in any thoughts you might have about what it would like to make this a new feature for the existing |
Thanks for the quick feedback! The problem with Integrating the changes to the existing rewrite plugin would definitely be possible, however, the biggest problem I see with that is the config format. |
Nice; thanks for the extra details! All that makes sense to me. It seems like the next step may be writing some documentation—let us know if you need help with that! |
Thanks, I'll look into it and will post my draft when it's ready, I'd definitely appreciate your feedback then! |
3bc2376
to
06a8f76
Compare
Finally got around to writing some documentation. Please let me know if there's anything to add. |
06a8f76
to
efe7141
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this all looks good! I found a super minor typo in the new docs, but other than this (and the linter approving; I think it may have some style suggestions), I think this is ready to merge.
Thanks! Fixed the typo and (hopefully) most of the lint warnings. For the |
11c8a12
to
0a4e57f
Compare
@Maxr1998 If you could fix the issues causing the linting errors, you should be good to merge. |
Sure. I'll have to find out how I can suppress the remaining documentation issues then. |
Don't suppress them, just fix them. They give clear instructions on what to do. |
This plugin allows rewriting fields based on a given library query. This can be helpful, for example, when an artist was renamed but you'd like to keep their older releases under their old name, or if you have a single track from a Various Artists release and want to have it included with the original artist.
54e35b9
to
9660dd6
Compare
Curiously, most if not all other plugins suppress all pydoc warnings. I assumed that was an accepted practice. Nonetheless, I fixed the remaining linter warnings. The PR should be mergeable now. |
Thank you. We're starting to enforce linting and formatting more rigorously so there's no reason not to start now. Thanks for fixing them. |
Description
This plugin allows rewriting fields based on a given library query. This can be helpful, for example, when an artist was renamed but you'd like to keep their older releases under their old name, or if you have a single track from a Various Artists release and want to have it included with the original artist.
Example configuration (restores the old name of a recently renamed artist for releases before 2023):
To Do
docs/changelog.rst
near the top of the document.)Depending on whether this feature is desired, I'll address the remaining points.