Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #4973 #4974

Merged
merged 2 commits into from
Oct 26, 2023
Merged

Fixes #4973 #4974

merged 2 commits into from
Oct 26, 2023

Conversation

fhchl
Copy link
Contributor

@fhchl fhchl commented Oct 22, 2023

Description

Fixes #4973.

This seemed obvious. I haven't run the test suit locally.

To Do

  • Documentation. (If you've add a new command-line flag, for example, find the appropriate page under docs/ to describe it.)
  • Changelog. (Add an entry to docs/changelog.rst near the top of the document.)
  • Tests. (Encouraged but not strictly required.)

@sampsyo
Copy link
Member

sampsyo commented Oct 25, 2023

Looks right to me! Would you mind adding a quick changelog entry describing the bug that was fixed?

@fhchl
Copy link
Contributor Author

fhchl commented Oct 26, 2023

Looks right to me! Would you mind adding a quick changelog entry describing the bug that was fixed?

Done! :)

@sampsyo
Copy link
Member

sampsyo commented Oct 26, 2023

Excellent; many thanks!

@sampsyo sampsyo merged commit 6655760 into beetbox:master Oct 26, 2023
13 checks passed
@JOJ0
Copy link
Member

JOJ0 commented Dec 11, 2023

@fhchl I guess you ment Discogs, not Discord in the changelog entry. I'll quickfix that in master :-)

@fhchl
Copy link
Contributor Author

fhchl commented Dec 11, 2023

@fhchl I guess you ment Discogs, not Discord in the changelog entry. I'll quickfix that in master :-)

Ups! Well spotted and thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

discogs: TypeError whenever artist and title are empty
3 participants