advancedrewrite: Support simple syntax and improve advanced syntax #5044
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Maxr1998
force-pushed
the
advancedrewrite-rewrite
branch
from
198d2e2
to
799ecee
Compare
Maxr1998
force-pushed
the
advancedrewrite-rewrite
branch
from
799ecee
to
7b30d21
Compare
|
Should be ready for review. Only need to add a changelog now, but I'll do that once the changes themselves are reviewed. |
Maxr1998
force-pushed
the
advancedrewrite-rewrite
branch
from
7b30d21
to
304a052
Compare
sampsyo
approved these changes
Dec 15, 2023
|
(I actually think this is ready to merge whenever you like, even without a changelog entry, since the plugin itself is new.) |
|
That's fine with me, the original changelog should already cover this plugin fairly well! So feel free to merge it as is. |
|
Wonderful! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Rework the
advancedrewriteplugin as discussed in #5002.Checklist