Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused functions #5103

Merged
merged 2 commits into from
Mar 1, 2024

Conversation

Josef-Friedrich
Copy link
Contributor

@Josef-Friedrich Josef-Friedrich commented Feb 10, 2024

Description

Remove unused functions. Fixes #5103.

The function ex_varassign is never called. The function ex_lvalue is only called by ex_varassign.

To Do

  • Documentation. (If you've added a new command-line flag, for example, find the appropriate page under docs/ to describe it.)
  • Changelog. (Add an entry to docs/changelog.rst to the bottom of one of the lists near the top of the document.)
  • Tests. (Very much encouraged but not strictly required.)

The function ex_varassign is never called. The function ex_lvalue
is only called by ex_varassign.
@Serene-Arc
Copy link
Contributor

Hi, your PR has failed the formatting test. If you could format your PR, that would be appreciated.

@Josef-Friedrich
Copy link
Contributor Author

Josef-Friedrich commented Feb 12, 2024

If I run tox locally format_check passes ... strange ...

@Serene-Arc
Copy link
Contributor

I just saw it in another PR too, with the same files. I'll have to investigate but it isn't your PR specifically. Sorry, my mistake.

@Serene-Arc Serene-Arc merged commit fa8b120 into beetbox:master Mar 1, 2024
12 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants