Add detection of "feat. X" parts in parentheses; Fix #5436 #5437
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When checking whether a title or artist contains a feature, it now also detects them when they are in parentheses or brackets, i.e., "Song Name (feat. XYZ)" will return true.
The previous version of the `plugins.feat_tokens` regular expression only matched "feat. X" parts if preceded by a space. This caused missed detections in the `ftintitle.contains_feat` function. This commit adds unit tests for the updated regex that also matches "feat. X" parts within parentheses and brackets
|
Thank you for the PR! The changelog has not been updated, so here is a friendly reminder to check if you need to add an entry. |
JOJ0
approved these changes
Sep 23, 2024
JOJ0
reviewed
Sep 23, 2024
Thanks! I have fixed the unnecessary comma in the regex and added a changelog entry. |
JOJ0
approved these changes
Sep 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #5436
The
ftintitle.contains_featfunction uses the regular expressionfeat_tokensfrombeets/plugins.pyto match existing feat. X parts. In the old version, the regex only matched "feat. X" parts when they are preceded by a space.This update adds matching "feat. X" parts in parentheses and brackets.
To Do
Documentation.docs/changelog.rstto the bottom of one of the lists near the top of the document.)