Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow fetchart to manipulate cover art candidates using all selected options #5440

Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open

Allow fetchart to manipulate cover art candidates using all selected options #5440

wants to merge 11 commits into from

Commits on Sep 25, 2024

  1. Replace resize and deinterlace with convert for IMBackend 

    This consolidates options passed to the fetchart plugin that would
require ImageMagick to adjust the cover art into a single function.
    @mlbaquerizo
    mlbaquerizo committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    11790db View commit details
    Browse the repository at this point in the history

  2. Replace resize and deinterlace with convert for PILBackend

    @mlbaquerizo
    mlbaquerizo committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    0ce5570 View commit details
    Browse the repository at this point in the history

  3. Add convert function to ArtResizer class to handle all conversion opt… 

    …ions
    @mlbaquerizo
    mlbaquerizo committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    4594187 View commit details
    Browse the repository at this point in the history

  4. Update fetchart plugin Candidate validation and add convert function 

    Candidate now returns False if Candidate is not valid and True if
it is. It is no longer concerned about any adjustments the plugin
needs to make to the Candidate.
The convert function will determine if the maxwidth, max_filesize,
cover_format, or deinterlace options should be applied and passes
all applicable options to ArtResizer's convert.
    @mlbaquerizo
    mlbaquerizo committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    e667bf5 View commit details
    Browse the repository at this point in the history

  5. Update ArtResizer tests to use new convert method 

    A test for cover format was also added to ensure that an image
can be converted from png to jpg with deinterlacing
    @mlbaquerizo
    mlbaquerizo committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    201743e View commit details
    Browse the repository at this point in the history

Commits on Sep 26, 2024

  1. Add changelog entry for fetchart updates

    @mlbaquerizo
    mlbaquerizo committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    015d1e7 View commit details
    Browse the repository at this point in the history

  2. Fix dict syntax error and update art tests to use new convert method

    @mlbaquerizo
    mlbaquerizo committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    244c9d0 View commit details
    Browse the repository at this point in the history

  3. Make test png smaller

    @mlbaquerizo
    mlbaquerizo committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    26a5fa3 View commit details
    Browse the repository at this point in the history

  4. Add result_path = source back in

    @mlbaquerizo
    mlbaquerizo committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    1af1ea1 View commit details
    Browse the repository at this point in the history

  5. Add test for resize and reformat at the same time

    @mlbaquerizo
    mlbaquerizo committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    e71bad7 View commit details
    Browse the repository at this point in the history

  6. Artresizer: Remove convert_format functions for PIL and IM backends 

    These functions have been replaced by `convert`
    @mlbaquerizo
    mlbaquerizo committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    90d026a View commit details
    Browse the repository at this point in the history