-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ftintitle: Fix false positives in "feat. X" detection in title #5442
Commits on Sep 26, 2024
-
Fix false positives in "feat. X" detection in ftintitle
The old version of the `ftintitle.contains_feat` function could lead to false positives by matching words like "and" and "with" in the title, even if there was no "feat. X" part. With this commit, the `for_artist` keyword is explicitly passed to the `plugins.feat_tokens` function to disable these matches when matching a title (and not an artist).
Configuration menu - View commit details
-
Copy full SHA for c66eb10 - Browse repository at this point
Copy the full SHA c66eb10View commit details -
Add unit tests for separate "feat. X" detection
The unit tests for the `ftintitle.contains_feat` function are now split up for artist and title matching.
Configuration menu - View commit details
-
Copy full SHA for 6cb2e59 - Browse repository at this point
Copy the full SHA 6cb2e59View commit details -
Configuration menu - View commit details
-
Copy full SHA for 85fc8e5 - Browse repository at this point
Copy the full SHA 85fc8e5View commit details
Commits on Sep 30, 2024
-
Configuration menu - View commit details
-
Copy full SHA for ab86b2d - Browse repository at this point
Copy the full SHA ab86b2dView commit details -
Add reference to ftintitle plugin in changelog
Add references to the ftintitle plugin for the bug fixes beetbox#5441 and beetbox#5436 that are related to this plugin.
Configuration menu - View commit details
-
Copy full SHA for 71b5a96 - Browse repository at this point
Copy the full SHA 71b5a96View commit details -
Hardcode for_artist keyword in ftintitle plugin
Remove the optional `for_artist` keyword in the `ftintitle.contains_feat` function and hardcode it to False, since it is always used like this in the ftintitle plugin.
Configuration menu - View commit details
-
Copy full SHA for ed627c0 - Browse repository at this point
Copy the full SHA ed627c0View commit details -
Update ftintitle.contains_feat unit tests
Since the `for_artist` keyword has been removed from `ftintitle.contains_feat`, the unit tests need to be updated. This includes the deletion of the test cases that test the `for_artist=True` delimiters.
Configuration menu - View commit details
-
Copy full SHA for 669307c - Browse repository at this point
Copy the full SHA 669307cView commit details
Commits on Oct 1, 2024
-
Remove redundant unit tests for ftintitle plugin
Remove redundant unit tests for the `ftintitle.cotains_feat` function
Configuration menu - View commit details
-
Copy full SHA for 37879d0 - Browse repository at this point
Copy the full SHA 37879d0View commit details