Reworked #4709 after latest release

[arogl]

Description

Fixes #4709 SQL use of Double Quoted Strings.

Replacing #5236

• Changelog. (Add an entry to docs/changelog.rst to the bottom of one of the lists near the top of the document.)

[snejus]

I think there's there may be one more replacement left, see extra/_beet line 111:

		sqlcmd="select distinct value from item_attributes where key=='$1' and value!='';"

[arogl]

I think there's there may be one more replacement left, see extra/_beet line 111:

		sqlcmd="select distinct value from item_attributes where key=='$1' and value!='';"

I believe this is already correct when reviewing against the changes already made.

Double quotes surrounding the command and single quotes for variable use within the string

[snejus]

I think there's there may be one more replacement left, see extra/_beet line 111:

		sqlcmd="select distinct value from item_attributes where key=='$1' and value!='';"

I believe this is already correct when reviewing against the changes already made.

Double quotes surrounding the command and single quotes for variable use within the string

Ah you're completely right! My bad, got mixed up there.

[snejus]

I think I found something relevant!

beetsplug/web/__init__.py:            'SELECT DISTINCT "{}" FROM "{}" ORDER BY "{}"'.format(
CONTRIBUTING.rst:             rows = tx.query('SELECT DISTINCT "{0}" FROM "{1}" ORDER BY "{2}"'

[arogl]

I have updated the 2 files as requested

beetsplug/web/__init__.py:
CONTRIBUTING.rst:

Looking through the code I wonder if the changes in this PR should look to be updated to f-strings?

[snejus]

I have updated the 2 files as requested

beetsplug/web/__init__.py:
CONTRIBUTING.rst:

Looking through the code I wonder if the changes in this PR should look to be updated to f-strings?

I wouldn't think so - I guess it would be out of scope of your actual goal here