Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refs #1473 - Check for content before updating content size. #1557

Merged
merged 1 commit into from
Aug 15, 2022

Conversation

freakboy3742
Copy link
Member

On iOS, if a ScrollContainer widget doesn't have any content, the request to rehint the size of the widget will generate an error. This can happen if no content has been assigned to the widget; but it can also happen during app startup, as the first rehint occurs before any content is assigned.

Tested with the scrollcontainer demo app, plus the test case provided on #1473. The Scrollcontainer demo app raises errors associated with the use of Commands, but that doesn't stop the app from running.

PR Checklist:

  • All new features have been tested
  • All new features have been documented
  • I have read the CONTRIBUTING.md file
  • I will abide by the code of conduct

@freakboy3742 freakboy3742 changed the title Fixes 1473 - Check for content before updating content size. Fixes #1473 - Check for content before updating content size. Aug 15, 2022
@freakboy3742 freakboy3742 changed the title Fixes #1473 - Check for content before updating content size. Refs #1473 - Check for content before updating content size. Aug 15, 2022
@freakboy3742 freakboy3742 merged commit c9fabfb into beeware:main Aug 15, 2022
@freakboy3742 freakboy3742 deleted the scrollcontainer_size branch August 15, 2022 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant