Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make upstream window and app references weak to avoid reference cycles #2061

Closed
wants to merge 28 commits into from
Closed

Make upstream window and app references weak to avoid reference cycles #2061

wants to merge 28 commits into from

Commits on Aug 3, 2023

  1. Update docstrings and documentation for Window and MainWindow.

    @freakboy3742
    freakboy3742 committed Aug 3, 2023
    Configuration menu
    Copy the full SHA
    d3fd16d View commit details
    Browse the repository at this point in the history

  2. Add changenote.

    @freakboy3742
    freakboy3742 committed Aug 3, 2023
    Configuration menu
    Copy the full SHA
    8c09ef1 View commit details
    Browse the repository at this point in the history

  3. Migrated core tests to pytest.

    @freakboy3742
    freakboy3742 committed Aug 3, 2023
    Configuration menu
    Copy the full SHA
    d2eec81 View commit details
    Browse the repository at this point in the history

  4. Complete coverage of core dialogs.

    @freakboy3742
    freakboy3742 committed Aug 3, 2023
    Configuration menu
    Copy the full SHA
    7ee6369 View commit details
    Browse the repository at this point in the history

  5. Remove GTK window tests.

    @freakboy3742
    freakboy3742 committed Aug 3, 2023
    Configuration menu
    Copy the full SHA
    3e6bf86 View commit details
    Browse the repository at this point in the history

  6. Correct a spelling issue, and document an API rename.

    @freakboy3742
    freakboy3742 committed Aug 3, 2023
    Configuration menu
    Copy the full SHA
    cec300d View commit details
    Browse the repository at this point in the history

  7. Exclude some clases from interface tests.

    @freakboy3742
    freakboy3742 committed Aug 3, 2023
    Configuration menu
    Copy the full SHA
    a13683b View commit details
    Browse the repository at this point in the history

  8. Cocoa GUI tests for Window (excluding dialogs and toolbars.

    @freakboy3742
    freakboy3742 committed Aug 3, 2023
    Configuration menu
    Copy the full SHA
    32097ca View commit details
    Browse the repository at this point in the history

  9. Add menu items and keyboard shortcuts for close/minimize on macOS.

    @freakboy3742
    freakboy3742 committed Aug 3, 2023
    Configuration menu
    Copy the full SHA
    212fb89 View commit details
    Browse the repository at this point in the history

  10. Add GUI test of full screen mode.

    @freakboy3742
    freakboy3742 committed Aug 3, 2023
    Configuration menu
    Copy the full SHA
    f3bffde View commit details
    Browse the repository at this point in the history

  11. Converge on US spelling for resizable, closable

    @freakboy3742
    freakboy3742 committed Aug 3, 2023
    Configuration menu
    Copy the full SHA
    86e91ae View commit details
    Browse the repository at this point in the history

  12. Cocoa dialogs 100% coverage.

    @freakboy3742
    freakboy3742 committed Aug 3, 2023
    Configuration menu
    Copy the full SHA
    9f719f6 View commit details
    Browse the repository at this point in the history

  13. 100% coverage for Window on iOS.

    @freakboy3742
    freakboy3742 committed Aug 3, 2023
    Configuration menu
    Copy the full SHA
    e3613f2 View commit details
    Browse the repository at this point in the history

  14. Minor coverage tweaks.

    @freakboy3742
    freakboy3742 committed Aug 3, 2023
    Configuration menu
    Copy the full SHA
    7cd3fde View commit details
    Browse the repository at this point in the history

  15. GTK Window and Dialogs to 100%.

    @freakboy3742
    freakboy3742 committed Aug 3, 2023
    Configuration menu
    Copy the full SHA
    c867585 View commit details
    Browse the repository at this point in the history

  16. Tweak visibility handling to ensure complete coverage in testbed cond… 

    …itions.
    @freakboy3742
    freakboy3742 committed Aug 3, 2023
    Configuration menu
    Copy the full SHA
    066a384 View commit details
    Browse the repository at this point in the history

Commits on Aug 4, 2023

  1. Use blackbox as a testing WM.

    @freakboy3742
    freakboy3742 committed Aug 4, 2023
    Configuration menu
    Copy the full SHA
    3bd0b05 View commit details
    Browse the repository at this point in the history

  2. Rework file dialog setup handling to avoid CI failure.

    @freakboy3742
    freakboy3742 committed Aug 4, 2023
    Configuration menu
    Copy the full SHA
    054658d View commit details
    Browse the repository at this point in the history

  3. More test updates for CI's benefit.

    @freakboy3742
    freakboy3742 committed Aug 4, 2023
    Configuration menu
    Copy the full SHA
    e18c5b1 View commit details
    Browse the repository at this point in the history

Commits on Aug 5, 2023

  1. Restructure menu creation for cocoa.

    @freakboy3742
    freakboy3742 committed Aug 5, 2023
    Configuration menu
    Copy the full SHA
    59cfb50 View commit details
    Browse the repository at this point in the history

  2. Rework default title handling so MainWindow defaults to the formal na… 

    …me as a title.
    @freakboy3742
    freakboy3742 committed Aug 5, 2023
    Configuration menu
    Copy the full SHA
    4fffdbe View commit details
    Browse the repository at this point in the history

Commits on Aug 11, 2023

  1. Add a test of closing window explicitly.

    @freakboy3742
    freakboy3742 committed Aug 11, 2023
    Configuration menu
    Copy the full SHA
    ce4130d View commit details
    Browse the repository at this point in the history

Commits on Aug 16, 2023

  1. Merge branch 'main' into audit-window

    @freakboy3742
    freakboy3742 committed Aug 16, 2023
    Configuration menu
    Copy the full SHA
    a04ad63 View commit details
    Browse the repository at this point in the history

  2. Insert a pause on app exit to make sure Briefcase gets all the app logs.

    @freakboy3742
    freakboy3742 committed Aug 16, 2023
    Configuration menu
    Copy the full SHA
    cc2df8b View commit details
    Browse the repository at this point in the history

  3. Make app and window back references weak.

    @freakboy3742
    freakboy3742 committed Aug 16, 2023
    Configuration menu
    Copy the full SHA
    f8a8773 View commit details
    Browse the repository at this point in the history

  4. Roll out weakref change across other backends.

    @freakboy3742
    freakboy3742 committed Aug 16, 2023
    Configuration menu
    Copy the full SHA
    b6fdd2d View commit details
    Browse the repository at this point in the history

  5. Add weakrefs to dummy, and a test of GC on the live backends.

    @freakboy3742
    freakboy3742 committed Aug 16, 2023
    Configuration menu
    Copy the full SHA
    c9ed0f8 View commit details
    Browse the repository at this point in the history

  6. Corrected some inheritance issues with iOS containers.

    @freakboy3742
    freakboy3742 committed Aug 16, 2023
    Configuration menu
    Copy the full SHA
    73714f6 View commit details
    Browse the repository at this point in the history