Change the window size of the switch example #906
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…and third checkbox
freakboy3742
approved these changes
May 14, 2020
There was a problem hiding this comment.
Thanks for the cleanup! As an immediate workaround a for a problem with the demo, this is great!
However, there's possibly a bug underneath all this; if a user describes a layout geometry that can't fit in the specified window size, we should at the very least be reporting this as a warning, and potentially expanding the window to the "smallest viable size".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change the window size of the switch example
The window height was too small to display the third checkbox.
Removed unused variable.
It is no longer required to resize the window (height) to see the third checkbox.
PR Checklist: