Rewrite NorwegianDateUtil to use java.time #72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
runeflobakk
reviewed
Sep 19, 2024
eivindw
approved these changes
Sep 20, 2024
java.util.Date and java.util.Calendar is old now and we don't want to use that any more. Breaking changes: We use ZonedDateTime in stead of Date to represent a date to check for working days. The list of holidays are now a NavigableSet<LocalDate> and not a Date[]. Co-authored-by: tobiasgwaaler Co-authored-by: runeflobakk Co-authored-by: martin-jackson Co-authored-by: hhaga Co-authored-by: fredrbus
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
java.util.Date and java.util.Calendar is old now and we don't want to
use that any more.
Breaking changes:
We use ZonedDateTime in stead of Date to represent a date to check
for working days.
The list of holidays are now a NavigableSet and not a Date[].