Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File that fails check should give some indication of the formatting that was missing. #182

Closed
belav opened this issue May 6, 2021 · 2 comments · Fixed by #230
Closed
Milestone

Comments

@belav
Copy link
Owner

belav commented May 6, 2021

When the --check option is used, the output only contains if a file was not formatted. It doesn't contain any indication of what part of the file wasn't formatted.
Theoretically you can just run csharpier on the file, but in the case where the --check appears to be a false positive, not having a message means it is harder to track down why it failed.

@belav belav added this to the 0.9.3 milestone May 6, 2021
@belav
Copy link
Owner Author

belav commented May 6, 2021

I can reproduce this by downloading the zip of the repo and running --check against that. That means I should be able to use the debug version to step through what is going on.

@belav
Copy link
Owner Author

belav commented May 6, 2021

It appears that SyntaxNodeComparerTests formats differently based on if it has \r\n or \n as line endings. So line endings must be included somehow in the width of strings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant