Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify ObjectCreationExpression with Initializer to use space brace #309

Merged
merged 1 commit into from
Jun 16, 2021

Conversation

belav
Copy link
Owner

@belav belav commented Jun 14, 2021

closes #113

@@ -17,8 +17,7 @@ public class ClassName
private SomeObject SomeLongerName = new SomeObject(
"lkjasdflkjasdfkljaskldjf",
"klasldkfaksdfasdfkjasdklf"
)
{
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I kind of hate how C# creators picked the stupid break-before-curly pattern with no thought for readability just to be different from Java. It's forcing us to be so inconsistent with when we use space brace. 😾

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I kind of want csharpier to not break-before-curly, but am worried that would turn off a lot of people.
I think things are starting to get more consistent, but there are definitely still some edge cases that need to get handled.

@belav belav merged commit f82bd8b into master Jun 16, 2021
@belav belav deleted the initializer-space-brace branch June 16, 2021 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Format ObjectCreationExpression with Initializer consistently
2 participants