Require directoryOrFile argument when not piping stdin #388
Conversation
belav
force-pushed
the
fix-check
branch
19 times, most recently
from
3462bbb
to
e821b76
Compare
belav
changed the title
belav
force-pushed
the
fix-check
branch
2 times, most recently
from
57e2aa1
to
c3ceb1e
Compare
Formatting a file that wasn't already formatted Working on powershell script for testing cli in workflow
There was a problem hiding this comment.
Okay, actually looked through the PS code this time.
Looks pretty good - made some minor comments that might be worth doing.
Also, is there an easy way of importing other scripts in powershell? You have a lot of repeated variables (especially involving paths) in your scripts. If you can extract them to some common file and import them, it's probably worth doing.
Scripts/CreateTestingPR.ps1
Outdated
| @@ -34,7 +34,7 @@ if ($firstRun) | |||
| & git reset --hard | |||
| & git checkout -b $preBranch | |||
|
|
|||
| dotnet $csharpierProject\Src\CSharpier\bin\Release\net5.0\dotnet-csharpier.dll | |||
| dotnet $csharpierProject\Src\CSharpier\bin\Release\net5.0\dotnet-csharpier.dll . | |||
There was a problem hiding this comment.
probably worth making a $csharpier variable like you do in TestCli.ps.
There was a problem hiding this comment.
Also, github won't let me make comments on lines that are not part of the diff, but it's probably worth putting Release into a variable and referencing it here and in the build command.
You'll probably never change build configuration, but I'm a stickler for not repeating code 😏
| @@ -46,7 +46,7 @@ foreach($folder in Get-ChildItem $csharpierRepos) { | |||
|
|
|||
| Push-Location $csharpierRepos | |||
|
|
|||
| dotnet $csharpierProject\Src\CSharpier\bin\Release\net5.0\dotnet-csharpier.dll | |||
| dotnet $csharpierProject\Src\CSharpier\bin\Release\net5.0\dotnet-csharpier.dll . | |||
There was a problem hiding this comment.
The 2 comments I made about CreateTestingPr.ps1 apply to this file too.
This also includes creating a number of tests that run with a github workflow to ensure we don't introduce bugs into the CLI with any later changes.
closes #381