-
-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Require directoryOrFile argument when not piping stdin #388
Conversation
3462bbb
to
e821b76
Compare
57e2aa1
to
c3ceb1e
Compare
Formatting a file that wasn't already formatted Working on powershell script for testing cli in workflow
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, actually looked through the PS code this time.
Looks pretty good - made some minor comments that might be worth doing.
Also, is there an easy way of importing other scripts in powershell? You have a lot of repeated variables (especially involving paths) in your scripts. If you can extract them to some common file and import them, it's probably worth doing.
Scripts/CreateTestingPR.ps1
Outdated
@@ -34,7 +34,7 @@ if ($firstRun) | |||
& git reset --hard | |||
& git checkout -b $preBranch | |||
|
|||
dotnet $csharpierProject\Src\CSharpier\bin\Release\net5.0\dotnet-csharpier.dll | |||
dotnet $csharpierProject\Src\CSharpier\bin\Release\net5.0\dotnet-csharpier.dll . |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
probably worth making a $csharpier
variable like you do in TestCli.ps
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, github won't let me make comments on lines that are not part of the diff, but it's probably worth putting Release
into a variable and referencing it here and in the build command.
You'll probably never change build configuration, but I'm a stickler for not repeating code 😏
@@ -46,7 +46,7 @@ foreach($folder in Get-ChildItem $csharpierRepos) { | |||
|
|||
Push-Location $csharpierRepos | |||
|
|||
dotnet $csharpierProject\Src\CSharpier\bin\Release\net5.0\dotnet-csharpier.dll | |||
dotnet $csharpierProject\Src\CSharpier\bin\Release\net5.0\dotnet-csharpier.dll . |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The 2 comments I made about CreateTestingPr.ps1
apply to this file too.
This also includes creating a number of tests that run with a github workflow to ensure we don't introduce bugs into the CLI with any later changes.
closes #381